Added yearly goal affordances to mobile view in my books page #10208
+45
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| $ year_markup = year_span(year) | ||
| <a class="set-reading-goal-link li-title-desktop" data-ol-link-track="MyBooksLandingPage|SetReadingGoal"href="javascript:;"> | ||
| $:_('%(year_span)s reading goal', year_span=year_markup) | ||
| <img class="icon-link__image li-count" src="/static/images/icons/right-chevron.svg"> |
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
for more information, see https://pre-commit.ci
|
I have done the changes and the VID_20241229_205845.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10168
Fix
At present the UI does not have the option to set the yearly goals in Mobile view (as it is present in the side bar which is not included in the mobile view). This PR adds the option to set the yearly goals in the main body in mobile view.
Testing
Screenshot
After setting a particular goal
In laptop view
Stakeholders
@jimchamp @mekarpeles