-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added yearly goal affordances to mobile view in my books page #10208
base: master
Are you sure you want to change the base?
Added yearly goal affordances to mobile view in my books page #10208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
$ year_markup = year_span(year) | ||
<a class="set-reading-goal-link li-title-desktop" data-ol-link-track="MyBooksLandingPage|SetReadingGoal"href="javascript:;"> | ||
$:_('%(year_span)s reading goal', year_span=year_markup) | ||
<img class="icon-link__image li-count" src="/static/images/icons/right-chevron.svg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative. This is a problem for people using screen readers.
for more information, see https://pre-commit.ci
I have done the changes and the VID_20241229_205845.mp4 |
Part of the problem is that there is only expected to be one dialog with id To ensure that there is only one
Then, remove the other reading goal form native dialogs from You will run into a similar issue when a new goal is submitted. The view is updated by the To fix this, you'll likely want to update this line to use |
Closes #10168
Fix
At present the UI does not have the option to set the yearly goals in Mobile view (as it is present in the side bar which is not included in the mobile view). This PR adds the option to set the yearly goals in the main body in mobile view.
Testing
Screenshot
After setting a particular goal
In laptop view
Stakeholders
@jimchamp @mekarpeles