Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix edition description wording #10215

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix edition description wording #10215

merged 1 commit into from
Dec 30, 2024

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Dec 28, 2024

Closes #10214

Technical

Adding a simple conditional to link to the correct section and have the right description.

Testing

Work: http://localhost:8080/works/OL54120W/The_wit_wisdom_of_Mark_Twain
Edition: http://localhost:8080/books/OL2058361M/The_wit_wisdom_of_Mark_Twain

Try clicking the edit buttons. Works well now.

Screenshot

Stakeholders

@cdrini

@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Dec 28, 2024
@RayBB RayBB requested a review from cdrini December 28, 2024 08:13
@mekarpeles mekarpeles merged commit ca940a7 into master Dec 30, 2024
7 checks passed
@mekarpeles mekarpeles self-assigned this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve wording around adding book descriptions
2 participants