start UP031 by fixing simple %s strings #10266
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10196
Before embarking on a journey to fix (or ask people to open many PRs) all of the issues I decided to open a PR with some of the simple fixes.
These were all suggested as "unsafe" fixes by ruff. They're unsafe because if the value was a tuple instead of a string then the f string behaves slightly differently. However, I've examined each of these examples pretty closely and don't see any cases where a tuple is likely to slip in.
Technical
https://docs.astral.sh/ruff/rules/printf-string-formatting/
Testing
I've clicked around on much of the site locally and didn't hit any errors but I didn't extensively check that all the code changed is triggered.
Screenshot
Stakeholders