Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate IDs of different types not being accepted on edition edit page #10275

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

sbwhitt
Copy link
Collaborator

@sbwhitt sbwhitt commented Jan 4, 2025

Closes #10274

Allows the same ID of different types to be entered on the edition edit page.

Technical

All ID values were being checked previously. Now, only the ID values of the matching type will be checked.

Testing

  • Navigate to edition edit page for any edition
  • Add an ID of any type (ex. OCAID)
  • Add the same ID under a different type (ex. LibriVox)
  • Verify that the ID is added and no error is displayed
  • Duplicate IDs for the same ID type should still be invalid

Screenshot

Stakeholders

@seabelis

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.54%. Comparing base (3025f5d) to head (625680e).
Report is 95 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10275      +/-   ##
==========================================
+ Coverage   17.44%   17.54%   +0.09%     
==========================================
  Files          89       88       -1     
  Lines        4792     4765      -27     
  Branches      848      845       -3     
==========================================
  Hits          836      836              
+ Misses       3436     3410      -26     
+ Partials      520      519       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and working beautifully!

image

@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Jan 7, 2025
@RayBB
Copy link
Collaborator

RayBB commented Jan 7, 2025

@mekarpeles this one is good to go 👍

@mekarpeles mekarpeles merged commit ef4d1a7 into internetarchive:master Jan 7, 2025
4 checks passed
@mekarpeles
Copy link
Member

Thank you!

@sbwhitt sbwhitt deleted the fix/edition-id-input branch January 8, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Different identifiers with same values rejected on edition edit form
4 participants