-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community Batch Imports: add links between "Pending Imports" and "New Imports" pages for easier navigation. #10285
Conversation
for more information, see https://pre-commit.ci
@ananyakaligal at first glance this looks great. Perhaps @scottbarnes could review and merge as he's also worked on this feature? :) |
@RayBB I encountered the same issue, and I even addressed it to you previously. My approach to this was by adding the 'Submitter' column to the database in my local environment. It worked perfectly fine after that. |
@ananyakaligal could you do me a favor and create a GitHub issue for this? We should add this column to the data auto loaded when someone creates a local insurance. |
@RayBB Sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, one small issue with the selected
class, fixing that up and then merged. Thank you @ananyakaligal !
Closes #10154
What does this PR achieve?
This PR adds navigation links between the "Pending Imports" and "New Imports" pages for easier access. It enhances the user experience by providing direct links at the bottom of both pages, facilitating smoother transitions between the two sections.
Technical
Created a new Macro BatchImportNavigation.html to include the navigation links.
Updated the templates batch_import_view.html and batch_import_pending_view.html pages to include the new navigation menu via :macros.BatchImportNavigation().
Testing
Visit the "Pending Imports" page (/import/batch/pending) or "New Imports" page (/import/batch/new) and ensure there’s a navigation bar created for both the links.
Screenshot
Stakeholders
@RayBB, @scottbarnes