test: improve folder trash assertions

internxt · Mar 11, 2024 · b61f9cb · b61f9cb
1 parent 2f3aac5
commit b61f9cb
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/tests/context/virtual-drive/folders/__mocks__/FolderRemoteFileSystemMock.ts b/tests/context/virtual-drive/folders/__mocks__/FolderRemoteFileSystemMock.ts
@@ -9,7 +9,7 @@ import {
 
 export class FolderRemoteFileSystemMock implements RemoteFileSystem {
   private readonly persistMock = jest.fn();
-  public readonly trashMock = jest.fn();
+  private readonly trashMock = jest.fn();
   public readonly moveMock = jest.fn();
   public readonly renameMock = jest.fn();
 
@@ -24,7 +24,9 @@ export class FolderRemoteFileSystemMock implements RemoteFileSystem {
   }
 
   trash(id: number): Promise<void> {
-    return this.trashMock(id);
+    expect(this.trashMock).toBeCalledWith(id);
+
+    return this.trashMock();
   }
 
   move(folder: Folder): Promise<void> {
@@ -50,4 +52,15 @@ export class FolderRemoteFileSystemMock implements RemoteFileSystem {
       parentId: folder.parentId as number,
     } satisfies FolderPersistedDto);
   }
+
+  shouldTrash(folder: Folder, error?: Error) {
+    this.trashMock(folder.id);
+
+    if (error) {
+      this.trashMock.mockRejectedValueOnce(error);
+      return;
+    }
+
+    this.trashMock.mockReturnValue(Promise.resolve());
+  }
 }
diff --git a/tests/context/virtual-drive/folders/application/FolderDeleter.test.ts b/tests/context/virtual-drive/folders/application/FolderDeleter.test.ts
@@ -32,14 +32,14 @@ describe('Folder deleter', () => {
   it('trashes an existing folder', async () => {
     const folder = FolderMother.exists();
 
+    remote.shouldTrash(folder);
+
     repository.searchByUuidMock.mockResolvedValueOnce(folder);
     jest
       .spyOn(allParentFoldersStatusIsExists, 'run')
       .mockResolvedValueOnce(true);
 
     await SUT.run(folder.uuid);
-
-    expect(remote.trashMock).toBeCalledWith(folder.id);
   });
 
   it('throws an error when trashing a folder already trashed', async () => {
@@ -80,7 +80,7 @@ describe('Folder deleter', () => {
     jest
       .spyOn(allParentFoldersStatusIsExists, 'run')
       .mockResolvedValueOnce(true);
-    remote.trashMock.mockRejectedValue(new Error('Error during the deletion'));
+    remote.shouldTrash(folder, new Error('Error during the deletion'));
 
     await SUT.run(folder.uuid);