[PB-1309]: Feat/Replace files when overwritting

src/apps/main/fordwardToWindows.ts

@@ -95,6 +95,24 @@ ipcMainDrive.on('FILE_CREATED', (_, payload) => {
   });
 });
 
+ipcMainDrive.on('FILE_UPDATED', (_, payload) => {
+  const { nameWithExtension } = payload;
+
+  broadcastToWindows('sync-info-update', {
+    action: 'UPDATED',
+    name: nameWithExtension,
+  });
+});
+
+ipcMainDrive.on('FILE_UPDATING', (_, payload) => {
+  const { nameWithExtension } = payload;
+
+  broadcastToWindows('sync-info-update', {
+    action: 'UPDATING',
+    name: nameWithExtension,
+  });
+});
+
 ipcMainDrive.on('FILE_UPLOAD_ERROR', (_, payload) => {
   const { nameWithExtension } = payload;
 
@@ -130,3 +148,12 @@ ipcMainDrive.on('FILE_DELETION_ERROR', (_, payload: FileErrorInfo) => {
     name: nameWithExtension,
   });
 });
+
+ipcMainDrive.on('FILE_UPDATE_ERROR', (_, payload: FileErrorInfo) => {
+  const { nameWithExtension } = payload;
+
+  broadcastToWindows('sync-info-update', {
+    action: 'UPDATE_ERROR',
+    name: nameWithExtension,
+  });
+});

src/apps/main/tray/handlers.ts

@@ -60,6 +60,14 @@ ipcMainDrive.on('FILE_UPLOADED', () => {
   setTrayStatus('IDLE');
 });
 
+ipcMainDrive.on('FILE_UPDATING', () => {
+  setTrayStatus('SYNCING');
+});
+
+ipcMainDrive.on('FILE_UPDATED', () => {
+  setTrayStatus('IDLE');
+});
+
 ipcMainDrive.on('FILE_UPLOAD_ERROR', () => {
   setTrayStatus('ALERT');
 });
@@ -75,3 +83,7 @@ ipcMainDrive.on('FILE_RENAME_ERROR', () => {
 ipcMainDrive.on('FILE_DELETION_ERROR', () => {
   setTrayStatus('ALERT');
 });
+
+ipcMainDrive.on('FILE_UPDATE_ERROR', () => {
+  setTrayStatus('ALERT');
+});

src/apps/renderer/hooks/useSyncInfoSubscriber.tsx

@@ -16,6 +16,7 @@ export function useSyncInfoSubscriber() {
 
       const itemIsAnError = [
         'UPLOAD_ERROR',
+        'UPDATE_ERROR',
         'DOWNLOAD_ERROR',
         'RENAME_ERROR',
         'DELETE_ERROR',
@@ -33,7 +34,7 @@ export function useSyncInfoSubscriber() {
   function clearItems() {
     setProcessInfoUpdatedPayload((current) =>
       current.filter((item) =>
-        ['UPLOADING', 'DOWNLOADING', 'RENAMING', 'DELETING'].includes(
+        ['UPLOADING', 'DOWNLOADING', 'RENAMING', 'DELETING', 'UPDATING'].includes(
           item.action
         )
       )
@@ -47,6 +48,7 @@ export function useSyncInfoSubscriber() {
           item.action !== 'UPLOADING' &&
           item.action !== 'DOWNLOADING' &&
           item.action !== 'RENAMING' &&
+          item.action !== 'UPDATING' &&
           item.action !== 'DELETING'
       );
     });

src/apps/shared/IPC/events/drive.ts

@@ -1,10 +1,3 @@
-type FolderEvents = {
-  FOLDER_CREATING: (payload: { name: string }) => void;
-  FOLDER_CREATED: (payload: { name: string }) => void;
-  FOLDER_RENAMING: (payload: { oldName: string; newName: string }) => void;
-  FOLDER_RENAMED: (payload: { oldName: string; newName: string }) => void;
-};
-
 export type FileInfo = {
   name: string;
   extension: string;
@@ -33,6 +26,12 @@ type UploadEvents = {
   FILE_UPLOAD_ERROR: (payload: FileErrorInfo) => void;
 };
 
+type UpdateEvents = {
+  FILE_UPDATING: (payload: FileInfo) => void;
+  FILE_UPDATED: (payload: FileInfo) => void;
+  FILE_UPDATE_ERROR: (payload: FileErrorInfo) => void;
+};
+
 type DownloadEvents = {
   FILE_DOWNLOADING: (payload: FileProgressInfo) => void;
   FILE_DOWNLOADED: (payload: FileProgressInfo) => void;
@@ -57,6 +56,13 @@ type RenameEvents = {
   FILE_RENAME_ERROR: (payload: FileErrorInfo) => void;
 };
 
+type FolderEvents = {
+  FOLDER_CREATING: (payload: { name: string }) => void;
+  FOLDER_CREATED: (payload: { name: string }) => void;
+  FOLDER_RENAMING: (payload: { oldName: string; newName: string }) => void;
+  FOLDER_RENAMED: (payload: { oldName: string; newName: string }) => void;
+};
+
 type OverwriteEvents = {
   FILE_OVERWRITED: (payload: { nameWithExtension: string }) => void;
 };
@@ -78,6 +84,7 @@ type FileEvents = UploadEvents &
   RenameEvents &
   OverwriteEvents &
   MoveEvents &
-  CloneEvents;
+  CloneEvents &
+  UpdateEvents;
 
 export type DriveEvents = FolderEvents & FileEvents;

src/apps/shared/IPC/events/sync-engine.ts

@@ -115,6 +115,27 @@ export type FilesEvents = {
   FILE_OVERWRITTEN: (payload: { nameWithExtension: string }) => void;
 
   FILE_CLONED: (payload: FileUpdatePayload) => void;
+
+  FILE_UPDATING: (payload: {
+    name: string;
+    extension: string;
+    nameWithExtension: string;
+    size: number;
+  }) => void;
+
+  FILE_UPDATED: (payload: {
+    name: string;
+    extension: string;
+    nameWithExtension: string;
+    size: number;
+  }) => void;
+
+  FILE_UPDATE_ERROR: (payload: {
+    name: string;
+    extension: string;
+    nameWithExtension: string;
+    error: string;
+  }) => void;
 };
 
 export type SyncEngineInvocableFunctions = {

src/apps/shared/types.ts

@@ -213,6 +213,7 @@ export type ProcessIssue = ProcessInfoBase & {
     | 'DOWNLOAD_ERROR'
     | 'RENAME_ERROR'
     | 'DELETE_ERROR'
+    | 'UPDATE_ERROR'
     | 'METADATA_READ_ERROR';
 
   errorName: ProcessErrorName;
@@ -223,11 +224,11 @@ export type ProcessInfoUpdatePayload =
   | (ProcessInfoBase &
       (
         | {
-            action: 'UPLOADING' | 'DOWNLOADING' | 'RENAMING' | 'DELETING';
+            action: 'UPLOADING' | 'DOWNLOADING' | 'RENAMING' | 'DELETING' | 'UPDATING';
             progress: number;
           }
         | {
-            action: 'UPLOADED' | 'DOWNLOADED' | 'RENAMED' | 'DELETED';
+            action: 'UPLOADED' | 'DOWNLOADED' | 'RENAMED' | 'DELETED' | 'UPDATED';
           }
       ))
   | ProcessIssue;

src/apps/sync-engine/BindingManager.ts

@@ -163,6 +163,12 @@ export class BindingsManager {
           callback(false);
         }
       },
+      notifyFileUpdatedCallback: (
+        absolutePath: string,
+        callback: (acknowledge: boolean, id: string) => boolean
+      ) => {
+        controllers.updateFile.execute(absolutePath, callback);
+      },
       validateDataCallback: () => {
         Logger.debug('validateDataCallback');
       },

src/apps/sync-engine/callbacks-controllers/buildControllers.ts

@@ -4,6 +4,7 @@ import { DeleteController } from './controllers/DeleteController';
 import { DownloadFileController } from './controllers/DownloadFileController';
 import { NotifyPlaceholderHydrationFinished } from './controllers/NotifyPlaceholderHydrationFinished';
 import { RenameOrMoveController } from './controllers/RenameOrMoveController';
+import { UpdateFileController } from './controllers/UpdateFileController';
 import { OfflineRenameOrMoveController } from './controllers/offline/OfflineRenameOrMoveController';
 
 export function buildControllers(container: DependencyContainer) {
@@ -14,6 +15,11 @@ export function buildControllers(container: DependencyContainer) {
     container.offline.folderCreator
   );
 
+  const updateFileController = new UpdateFileController(
+    container.fileCreationOrchestrator,
+    container.fileUpdater
+  );
+
   const deleteController = new DeleteController(
     container.fileDeleter,
     container.folderDeleter
@@ -44,6 +50,7 @@ export function buildControllers(container: DependencyContainer) {
   return {
     addFile: addFileController,
     renameOrMove: renameOrMoveController,
+    updateFile: updateFileController,
     delete: deleteController,
     downloadFile: downloadFileController,
     offline: {

src/apps/sync-engine/callbacks-controllers/controllers/UpdateFileController.ts

@@ -0,0 +1,45 @@
+import { FileCreationOrchestrator } from '../../../../context/virtual-drive/boundaryBridge/application/FileCreationOrchestrator';
+import { FileUpdater } from '../../../../context/virtual-drive/files/application/FileUpdater';
+import { createFilePlaceholderId } from '../../../../context/virtual-drive/files/domain/PlaceholderId';
+import { CallbackController } from './CallbackController';
+import Logger from 'electron-log';
+
+
+type UpdateCallback = (acknowledge: boolean, id: string) => void;
+
+export class UpdateFileController extends CallbackController {
+
+  constructor(
+    private readonly fileCreationOrchestrator: FileCreationOrchestrator,
+    private readonly fileUpdater: FileUpdater,
+  ) {
+    super();
+  }
+
+  private updateFile = async (
+    oldContentsId: string,
+    callback: (acknowledge: boolean, id: string) => void
+  ) => {
+    try {
+      const newContentsId = await this.fileCreationOrchestrator.run(oldContentsId);
+      await this.fileUpdater.run(oldContentsId, newContentsId);
+      return callback(true, createFilePlaceholderId(newContentsId));
+    } catch (error: unknown) {
+      Logger.error('Error when updating a file: ', error);
+      callback(false, '');
+    }
+  };
+
+  async execute(contentsId: string, callback: UpdateCallback) {
+    const trimmedId = this.trim(contentsId);
+
+    if (this.isFilePlaceholder(trimmedId)) {
+      const [_, contentsId] = trimmedId.split(':');
+      Logger.debug(`Updating file: ${contentsId}`);
+      this.updateFile(contentsId, callback);
+      return;
+    }
+
+    throw new Error(`Placeholder Id not identified:  ${trimmedId}`);
+  }
+}

src/apps/sync-engine/dependency-injection/files/FilesContainer.ts

@@ -4,6 +4,7 @@ import { FileDeleter } from '../../../../context/virtual-drive/files/application
 import { FileFinderByContentsId } from '../../../../context/virtual-drive/files/application/FileFinderByContentsId';
 import { FilePathUpdater } from '../../../../context/virtual-drive/files/application/FilePathUpdater';
 import { FilePlaceholderCreatorFromContentsId } from '../../../../context/virtual-drive/files/application/FilePlaceholderCreatorFromContentsId';
+import { FileUpdater } from '../../../../context/virtual-drive/files/application/FileUpdater';
 import { FilesPlaceholderUpdater } from '../../../../context/virtual-drive/files/application/FilesPlaceholderUpdater';
 import { FilesPlaceholderCreator } from '../../../../context/virtual-drive/files/application/FilesPlaceholdersCreator';
 import { RepositoryPopulator } from '../../../../context/virtual-drive/files/application/RepositoryPopulator';
@@ -22,4 +23,5 @@ export interface FilesContainer {
   repositoryPopulator: RepositoryPopulator;
   filesPlaceholderCreator: FilesPlaceholderCreator;
   filesPlaceholderUpdater: FilesPlaceholderUpdater;
+  fileUpdater: FileUpdater;
 }

src/apps/sync-engine/dependency-injection/files/builder.ts

@@ -23,6 +23,9 @@ import { InMemoryFileRepository } from '../../../../context/virtual-drive/files/
 import { SDKRemoteFileSystem } from '../../../../context/virtual-drive/files/infrastructure/SDKRemoteFileSystem';
 import { NodeWinLocalFileSystem } from '../../../../context/virtual-drive/files/infrastructure/NodeWinLocalFileSystem';
 import { LocalFileIdProvider } from '../../../../context/virtual-drive/shared/application/LocalFileIdProvider';
+import { DependencyInjectionHttpClientsProvider } from '../common/clients';
+import { FileUpdater } from '../../../../context/virtual-drive/files/application/FileUpdater';
+import { HttpRemoteFileSystem } from '../../../../context/virtual-drive/files/infrastructure/HttpRemoteFileSystem';
 
 export async function buildFilesContainer(
   folderContainer: FoldersContainer,
@@ -36,8 +39,10 @@ export async function buildFilesContainer(
   const eventHistory = DependencyInjectionEventRepository.get();
   const { virtualDrive } = DependencyInjectionVirtualDrive;
   const sdk = await DependencyInjectionStorageSdk.get();
+  const clients = DependencyInjectionHttpClientsProvider.get();
 
-  const remoteFileSystem = new SDKRemoteFileSystem(sdk, crypt, user.bucket);
+  const remoteSDKFileSystem = new SDKRemoteFileSystem(sdk, crypt, user.bucket);
+  const remoteHTTPFileSystem = new HttpRemoteFileSystem(clients.newDrive);
   const localFileSystem = new NodeWinLocalFileSystem(
     virtualDrive,
     sharedContainer.relativePathToAbsoluteConverter
@@ -48,21 +53,27 @@ export async function buildFilesContainer(
   const fileFinderByContentsId = new FileFinderByContentsId(repository);
 
   const fileDeleter = new FileDeleter(
-    remoteFileSystem,
+    remoteSDKFileSystem,
     localFileSystem,
     repository,
     folderContainer.allParentFoldersStatusIsExists,
     ipcRendererSyncEngine
   );
 
+  const fileUpdater = new FileUpdater(
+    remoteHTTPFileSystem,
+    repository,
+    ipcRendererSyncEngine
+  );
+
   const sameFileWasMoved = new SameFileWasMoved(
     repository,
     localFileSystem,
     eventHistory
   );
 
   const filePathUpdater = new FilePathUpdater(
-    remoteFileSystem,
+    remoteSDKFileSystem,
     localFileSystem,
     repository,
     fileFinderByContentsId,
@@ -72,7 +83,7 @@ export async function buildFilesContainer(
   );
 
   const fileCreator = new FileCreator(
-    remoteFileSystem,
+    remoteSDKFileSystem,
     repository,
     folderContainer.folderFinder,
     fileDeleter,
@@ -120,6 +131,7 @@ export async function buildFilesContainer(
     repositoryPopulator: repositoryPopulator,
     filesPlaceholderCreator,
     filesPlaceholderUpdater,
+    fileUpdater,
   };
 
   return { container, subscribers: [] };

src/apps/sync-engine/dependency-injection/folders/builder.ts

@@ -1,4 +1,4 @@
-import { NodeWinLocalFileSystem } from '../../../../context/virtual-drive/folders/infrastructure/NodeWinLocalFileSystem';
+import { NodeWinLocalFolderSystem } from '../../../../context/virtual-drive/folders/infrastructure/NodeWinLocalFolderSystem';
 import { AllParentFoldersStatusIsExists } from '../../../../context/virtual-drive/folders/application/AllParentFoldersStatusIsExists';
 import { FolderByPartialSearcher } from '../../../../context/virtual-drive/folders/application/FolderByPartialSearcher';
 import { FolderCreator } from '../../../../context/virtual-drive/folders/application/FolderCreator';
@@ -17,7 +17,7 @@ import { RetrieveAllFolders } from '../../../../context/virtual-drive/folders/ap
 import { SynchronizeOfflineModifications } from '../../../../context/virtual-drive/folders/application/SynchronizeOfflineModifications';
 import { SynchronizeOfflineModificationsOnFolderCreated } from '../../../../context/virtual-drive/folders/application/SynchronizeOfflineModificationsOnFolderCreated';
 import { FolderPlaceholderUpdater } from '../../../../context/virtual-drive/folders/application/UpdatePlaceholderFolder';
-import { HttpRemoteFileSystem } from '../../../../context/virtual-drive/folders/infrastructure/HttpRemoteFileSystem';
+import { HttpRemoteFolderSystem } from '../../../../context/virtual-drive/folders/infrastructure/HttpRemoteFolderSystem';
 import { InMemoryFolderRepository } from '../../../../context/virtual-drive/folders/infrastructure/InMemoryFolderRepository';
 import { InMemoryOfflineFolderRepository } from '../../../../context/virtual-drive/folders/infrastructure/InMemoryOfflineFolderRepository';
 import { ipcRendererSyncEngine } from '../../ipcRendererSyncEngine';
@@ -38,8 +38,8 @@ export async function buildFoldersContainer(
 
   const repository = new InMemoryFolderRepository();
 
-  const localFileSystem = new NodeWinLocalFileSystem(virtualDrive);
-  const remoteFileSystem = new HttpRemoteFileSystem(
+  const localFileSystem = new NodeWinLocalFolderSystem(virtualDrive);
+  const remoteFileSystem = new HttpRemoteFolderSystem(
     clients.drive,
     clients.newDrive
   );