[PB-1513]: Fix/loop-when-delete-files #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoanVicens
reviewed
Jan 19, 2024
| run(contentId: File['contentsId'], folderContentId: Folder['uuid']): boolean { | ||
| const file = this.repository.searchByPartial({ contentsId: contentId }); | ||
| const folder = this.folderFinder.findFromId(file?.folderId); | ||
| const [_, folderUuid] = folder.placeholderId.split(':'); |
There was a problem hiding this comment.
folder has the UUID stored, so you can simply do folder.uuid
JoanVicens
reviewed
Jan 19, 2024
|
|
||
| run(contentId: File['contentsId'], folderContentId: Folder['uuid']): boolean { | ||
| const file = this.repository.searchByPartial({ contentsId: contentId }); | ||
| const folder = this.folderFinder.findFromId(file?.folderId); |
There was a problem hiding this comment.
I would avoid having findFromId with the id optional. If there is no ID we already know that it will fail to find it. So I would add a guard clause, this way if the file is not found, then the error thrown is from the file not being in the repo and not that a folder
JoanVicens
reviewed
Jan 19, 2024
| } | ||
|
|
||
| private async executeFn(item: string) { | ||
| this.queue.delete(item); |
There was a problem hiding this comment.
Shouldn't be the other way around, first execute the function and delete it from the queue? I'm worried that if the deletion takes too long it can allow to delete files that does not need to be deleted
JoanVicens
reviewed
Jan 19, 2024
JoanVicens
approved these changes
Jan 25, 2024
miguelsw
changed the base branch from
master-erb
to
monitoring-polling-system
miguelsw
force-pushed
the
fix/lopp-deleting-files
branch
from
8e2b062 to
e5d858a
Compare
|
c27gc
approved these changes
Feb 9, 2024
cg27shokworks
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Update: