Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[_] fix: ensure newer files are included #492

Merged
merged 7 commits into from
Apr 30, 2024

Conversation

JoanVicens
Copy link
Contributor

@JoanVicens JoanVicens commented Apr 15, 2024

To avoid prs that depend on other prs. This one removes the StorageApp for the RemoteSyncManager and changes the checkpoint of files and folders to be 6 hours before the last updated item.

The StorageApp has been deleted and instead of managing the lastFilesSyncAt and lastFoldersSyncAt, we take advantage of the local database to query those values. This avoids showing the onboarding window on every login, the reset of the selected language, and the creation of new devices after logging out and back in.

When fetching the items we check for items 6 hours previous to the latest one saved to avoid missing some items when the backend does not return them on the synchronization.

@JoanVicens JoanVicens requested a review from miguelsw April 15, 2024 10:52
@JoanVicens JoanVicens marked this pull request as ready for review April 15, 2024 11:53
@JoanVicens JoanVicens marked this pull request as draft April 15, 2024 11:56
@JoanVicens JoanVicens marked this pull request as ready for review April 15, 2024 13:02
@miguelsw miguelsw mentioned this pull request Apr 17, 2024
8 tasks
@JoanVicens JoanVicens changed the base branch from feat/2-0-7-release to feat/2-0-8-features April 22, 2024 09:42
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@miguelsw miguelsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@miguelsw miguelsw merged commit 4653cec into feat/2-0-8-features Apr 30, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants