-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PB-267]: Feat/Add lastPasswordChangeAt to users #382
[PB-267]: Feat/Add lastPasswordChangeAt to users #382
Conversation
larry-internxt
commented
Feb 27, 2023
•
edited
Loading
edited
- Added lastPasswordChangeAt column to users
- Added logic to invalidate token on middleware when lastPasswordChangeAt is greater than token's iat
SonarCloud Quality Gate failed. 0 Bugs 0.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
724193e
to
cca3762
Compare
Quality Gate failedFailed conditions 0.0% Coverage on New Code (required ≥ 80%) |
We need to also add iat to new tokens. I made a small PR adding it, moving out the iat from the payload (to align with what drive-server-wip expects) and 1 small naming change. |
…o-users-small-changes [PB-267]: feat/small changes to add future iat to newTokens
Quality Gate failedFailed conditions 0.0% Coverage on New Code (required ≥ 80%) |
@sg-gs I think this is ready to go. I just made 3 changes. There are some miliseconds that are being lost when we convert from Date to IAT so that's why this PR issues a new token with a iat a little time ahead. Otherwise, the comparison between lastPassword < iat is going to fail because of the miliseconds. Other options were:
|