Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PB-2228]: feat/real time changes apn #445

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Conversation

jzunigax2
Copy link
Contributor

@jzunigax2 jzunigax2 commented Jul 1, 2024

Related issue:
https://inxt.atlassian.net/browse/PB-2228

Implemented APN to send push notifications to mac clients signaling changes in their virtual storage system. In every place where a post to notifications was triggered a method attempts to find any macos notification tokens (table created in internxt/drive-server-wip#341) and if there are any it attempts to send a notification.

@jzunigax2 jzunigax2 added the enhancement New feature or request label Jul 1, 2024
@jzunigax2 jzunigax2 self-assigned this Jul 1, 2024
@jzunigax2 jzunigax2 changed the title Feat/real time changes apn [PB-2228]: feat/real time changes apn Jul 1, 2024
@jzunigax2 jzunigax2 requested a review from sg-gs July 2, 2024 21:22
@jzunigax2 jzunigax2 marked this pull request as ready for review July 2, 2024 22:12
@jzunigax2 jzunigax2 requested a review from apsantiso as a code owner July 2, 2024 22:12
src/config/initializers/apn.ts Outdated Show resolved Hide resolved
src/config/initializers/apn.ts Outdated Show resolved Hide resolved
src/config/initializers/apn.ts Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jul 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
8.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@sg-gs
Copy link
Member

sg-gs commented Jul 3, 2024

Secrets have been set in production correctly. Merging @jzunigax2 @PixoDev

@sg-gs sg-gs merged commit 6591127 into master Jul 3, 2024
9 of 14 checks passed
@sg-gs sg-gs deleted the feat/real-time-changes-apn branch July 3, 2024 14:13
@sg-gs sg-gs restored the feat/real-time-changes-apn branch July 3, 2024 14:17
@sg-gs sg-gs deleted the feat/real-time-changes-apn branch November 13, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-for-preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants