[PB-1401, PB-1403] add blocked account view #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CandelR
requested changes
Jan 19, 2024
| } | ||
|
|
||
| setLoginError([castedError.message]); | ||
| setShowErrors(true); | ||
| if (castedError.message.includes('Your account has been blocked for security reasons. Please reach out to us')) { |
There was a problem hiding this comment.
This does not seem to be a good way to check the error, at the slightest change in the message it will stop working, and it will not take into account that a change in the message may break something
Use the status that returns the call or another signal.
CandelR
requested changes
Jan 19, 2024
CandelR
approved these changes
Jan 24, 2024
|
CandelR
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies:
internxt/drive-server-wip#250
internxt/sdk#185
New dependencies for Http Error code catching on login:
internxt/sdk#186
If this is not implemented, then we would need to compare the message string instead of the code to know if the user has been blocked.