-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: handle scipy failures due to renaming of scipy.sparse modules in v1.8 #6
Conversation
Signed-off-by: Connor Tann <[email protected]>
Signed-off-by: Connor Tann <[email protected]>
Signed-off-by: Connor Tann <[email protected]>
Thanks @connortann -- I'll put out a release out with this. |
v0.0.8 released on PyPI now. |
@paulbkoch that's great! Would you be able to make a release on conda-forge as well? I noticed on the feedstock repo there no auto-update Pull Request. On the current migrations page, it looks like the update to v0.0.8 has hit an error: https://conda-forge.org/status/#current_migrations
|
I'm not an owner of the feedstock repo. I think only Scott is, last I looked. If you end up getting access, can you also add me as a maintainer of the feedstock in case we take a dependency on slicer in the future for InterpretML. |
You know what, I'll ping Scott and ask him. |
Pinged Scott and asked him to add both of us @connortann as maintainers of the slicer feedstock. |
Hi @connortann -- We're both maintainers for the slicer feedstock now. Do you want to take up the release from there? |
Thanks! I'll take a look. I'm admittedly not particularly experienced with conda feedstocks but shall have a go getting the recipe updated. Talking of maintainers, please do let me know if you'd be interested in becoming a maintainer of shap: shap/shap#3559 |
Ok, I'll put out a release then. It's kind of a weird system that conda-forge uses, but I'm familiar with it. |
Thanks @connortann -- I think I'll pass on being a shap maintainer for now, but I'll let you know if anything changes in the future. I've got my hands pretty full at the moment since I'm still maintaining the interpret repo, and have more recently become involved in Scott's new Guidance project https://github.com/guidance-ai/guidance/ |
Hi @connortann -- Slicer v0.0.8 is on conda-forge. |
Fixes the unit tests, and closes #5
Changes:
After this change is in, it would be great to have a release if possible.