Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ca 264 display and manage status for assessments #115

Merged
merged 10 commits into from
Mar 11, 2024

Conversation

monsieurswag
Copy link
Contributor

No description provided.

@Mohamed-Hacene Mohamed-Hacene marked this pull request as draft March 5, 2024 16:12
remove is_draft
add status in page.svelte (todo: localization)
remove is_obsolete
@eric-intuitem
Copy link
Collaborator

The localisation shall be completed, otherwise this PR is almost ready.

…thub.com:intuitem/ciso-assistant-community into CA-264-Display-and-manage-status-for-assessments
@Mohamed-Hacene Mohamed-Hacene marked this pull request as ready for review March 11, 2024 07:31
@Alexdev8
Copy link
Contributor

All the tests are fixed 👍

Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but I wait @eric-intuitem review as I also worked on the PR

Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some missing translations, but this is progressing. Will open new tickets.

@eric-intuitem eric-intuitem merged commit 57867f4 into main Mar 11, 2024
12 checks passed
@eric-intuitem eric-intuitem deleted the CA-264-Display-and-manage-status-for-assessments branch March 11, 2024 20:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants