Remove the user list from the navigation sidebar for non-admin users #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is in draft until this problem is also fixed on the backend side |
… list view or the user-groups list view
|
A non-admin user still have the permission to fetch the list of user-groups in the Django API but this is not really critical |
Mohamed-Hacene
deleted the
CA-297-An-non-admin-can-see-users-list-and-click-on-user-detailed-view
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A non-admin can still access the user list going to the /users page by manually modifying its URL in the browser, so this is not a security fix at all.
This is just a simple frontend fix so that non-admin users don't have access to a page that is useless for them.