Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-level and implementation groups #364

Merged
merged 39 commits into from
May 8, 2024

Conversation

nas-tabchiche
Copy link
Contributor

No description provided.

Copy link

gitguardian bot commented May 6, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@nas-tabchiche nas-tabchiche requested a review from ab-smith May 6, 2024 16:38
@nas-tabchiche nas-tabchiche force-pushed the feat/implementation-groups branch from cbec541 to c5d4b54 Compare May 6, 2024 18:59
@nas-tabchiche nas-tabchiche force-pushed the feat/implementation-groups branch from 9cec6bb to 83836fb Compare May 6, 2024 19:30
@nas-tabchiche nas-tabchiche marked this pull request as ready for review May 6, 2024 19:56
@ab-smith ab-smith mentioned this pull request May 7, 2024
@nas-tabchiche nas-tabchiche force-pushed the feat/implementation-groups branch from bd22d8c to 608d647 Compare May 7, 2024 12:42
@ab-smith ab-smith marked this pull request as draft May 8, 2024 06:34
@ab-smith ab-smith marked this pull request as ready for review May 8, 2024 09:04
@ab-smith
Copy link
Contributor

ab-smith commented May 8, 2024

Score radial bar needs to consider the IG filter

Copy link
Contributor

@ab-smith ab-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let's go

@ab-smith ab-smith changed the title Feat/implementation groups Support multi-level and implementation groups May 8, 2024
@ab-smith ab-smith merged commit 14d56e5 into main May 8, 2024
14 checks passed
@ab-smith ab-smith deleted the feat/implementation-groups branch May 8, 2024 13:02
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
@ab-smith ab-smith linked an issue May 9, 2024 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the management of frameworks with multiple levels
3 participants