Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for the English translation #380

Merged
merged 2 commits into from
May 6, 2024

Conversation

krismas
Copy link
Contributor

@krismas krismas commented May 6, 2024

  • Folder -> Domain
  • Typos

@ab-smith ab-smith requested a review from eric-intuitem May 6, 2024 16:33
@ab-smith
Copy link
Contributor

ab-smith commented May 6, 2024

Merci @krismas 😊
LGTM,
We've merged the missing piece preventing the functional tests for external contributors; you can rebase now and we'll approve it

Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should be merged with main to pass tests.

@eric-intuitem eric-intuitem self-requested a review May 6, 2024 17:58
Copy link

gitguardian bot commented May 6, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@ab-smith ab-smith merged commit 7560726 into intuitem:main May 6, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
@krismas krismas deleted the 240506-translate-en branch May 7, 2024 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants