-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/inter framework mappings #584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts and focal_framework
To comply with OLIR, the relationship's subject is the focal requirement.
- Replace relationship field with coverage - Coverage is either full, partial or non_related - Remove rationale field - Point to a single reference requirement instead of many
nas-tabchiche
requested review from
Mohamed-Hacene,
monsieurswag,
ab-smith and
eric-intuitem
and removed request for
monsieurswag
June 26, 2024 15:27
Closed
Remove useless and misleading dependency to NameDescriptionMixin
rationalize mapping specification - mapping rules are grouped in a json field of a requirement_mapping_set to avoid useless granularity in the database and to simplify library updates for requirement_mapping_set.
Remove version for RequirementMappingSet, as this is a library object like others, and frameworks updates shall be minor (else a new framework shall be published, with a new urn)
Mohamed-Hacene
force-pushed
the
feat/inter-framework-mappings
branch
from
July 7, 2024 13:08
09dc878
to
db901fe
Compare
ab-smith
approved these changes
Jul 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional ok
@Mohamed-Hacene One important UX improvement will be to switch to the newly created audit |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.