Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve/rationalize object classes #73

Merged
merged 4 commits into from
Feb 25, 2024
Merged

Improve/rationalize object classes #73

merged 4 commits into from
Feb 25, 2024

Conversation

eric-intuitem
Copy link
Collaborator

After studying the relations between our classes, it appears that it is possible to rationalise them.

  • RootFolderMixin and FolderMixin are merged, with root folder being the default folder when creating an object. This will make it simpler in the future to allow objects to be creating either in the root folder or in a domain.
  • Redundant fields are removed.
  • created_at is moved in abstractBaseModel.
  • Classes are ordered in a more logical way.
  • RoleAssignment is attached to a folder (this was the last class not to be related to a folder).

Migrations are squashed.

@eric-intuitem
Rationalize all object classes
6f50527 
Make an inheritance patttern that is simpler and more logical
Put IAM object in logical order
@eric-intuitem
SImplify data model
34a33ff 
Fusion RootFolderMixin and FolderMixin
Move RefentialObjectMixin in core (where it is only used)
Move updated_at in AbstracBaseModel
Remove redundant fields (UUID, folder)
@eric-intuitem
Update models.py
12f98d4 
Reorder classes in a logical way
@eric-intuitem
Copy link
Collaborator Author

Important PR for data model stability

@eric-intuitem eric-intuitem merged commit dd7d212 into main Feb 25, 2024
9 of 10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2024
@Mohamed-Hacene Mohamed-Hacene deleted the improve/rationalize-object-classes branch April 3, 2024 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nas-tabchiche nas-tabchiche Awaiting requested review from nas-tabchiche

@Mohamed-Hacene Mohamed-Hacene Awaiting requested review from Mohamed-Hacene

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eric-intuitem