Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null property access at getBaseClassDependencyCount #1665

Merged

Conversation

notaphplover
Copy link
Member

Description

  • Fixed unexpected property access on null valeus when running planning checks on injected base classes.
  • Fixed ESM sourcemap links.

Related Issue

#1664

How Has This Been Tested?

  • Tests run successfully.
  • Sourcemaps target right ts files.

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.

@notaphplover notaphplover self-assigned this Dec 3, 2024
@notaphplover notaphplover changed the title Update get base class dependency count null access Update get base class dependency count null property access Dec 3, 2024
@notaphplover notaphplover changed the title Update get base class dependency count null property access Fix null property access at getBaseClassDependencyCount Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (f7dd2c8) to head (582c3b3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1665   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files          51       52    +1     
  Lines        1327     1332    +5     
  Branches      180      180           
=======================================
+ Hits         1315     1320    +5     
  Misses         11       11           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notaphplover notaphplover merged commit d787b8f into master Dec 3, 2024
4 checks passed
@notaphplover notaphplover deleted the fix/update-get-base-class-dependency-count-null-access branch December 3, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant