Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container with try get methods #1674

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

notaphplover
Copy link
Member

@notaphplover notaphplover commented Dec 4, 2024

Description

  • Updated container with tryGet.
  • Updated container with tryGetAsync.
  • Updated container with tryGetTagged.
  • Updated container with tryGetTaggedAsync.
  • Updated container with tryGetNamed.
  • Updated container with tryGetNamedAsync.
  • Updated container with tryGetAll.
  • Updated container with tryGetAllAsync.
  • Updated container with tryGetAllTagged.
  • Updated container with tryGetAllTaggedAsync.
  • Updated container with tryGetAllNamed.
  • Updated container with tryGetAllNamedAsync.

Related Issue

Closes #566

Motivation and Context

Discussed in #566

How Has This Been Tested?

  • Added unit tests to cover optional behavior.

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (fdbf854) to head (daa13dc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1674      +/-   ##
==========================================
+ Coverage   98.95%   99.11%   +0.16%     
==========================================
  Files          52       52              
  Lines        1343     1363      +20     
  Branches      184      184              
==========================================
+ Hits         1329     1351      +22     
+ Misses         13       11       -2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notaphplover notaphplover marked this pull request as ready for review December 5, 2024 00:06
@notaphplover notaphplover merged commit ee442fb into master Dec 5, 2024
4 checks passed
@notaphplover notaphplover deleted the feat/update-container-with-try-get-methods branch December 5, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New feature: Support defaultValues and tryGet* methods
1 participant