Skip to content

Commit

Permalink
fix: Fixed output tests that failed on some terminals
Browse files Browse the repository at this point in the history
  • Loading branch information
@christerswahn
christerswahn committed Dec 6, 2024
1 parent 399a016 commit a497208
Show file tree
Hide file tree
Showing 3 changed files with 103 additions and 99 deletions.
85 changes: 43 additions & 42 deletions packages/melos/test/commands/analyze_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import 'dart:io';

import 'package:melos/melos.dart';
import 'package:melos/src/common/io.dart';
import 'package:melos/src/common/utils.dart';
import 'package:path/path.dart' as p;
import 'package:pub_semver/pub_semver.dart';
import 'package:pubspec_parse/pubspec_parse.dart';
Expand Down Expand Up @@ -64,32 +65,32 @@ void main() {
expect(
logger.output.normalizeNewLines(),
ignoringAnsii(
r'''
$ melos analyze
'''
\$ melos analyze
└> dart analyze --fatal-infos
└> RUNNING (in 3 packages)
--------------------------------------------------------------------------------
${'-' * terminalWidth}
a:
Analyzing a...
info - main.dart:3:13 - Don't invoke 'print' in production code. Try using a logging framework. - avoid_print
info - main.dart:5:10 - Missing a newline at the end of the file. Try adding a newline at the end of the file. - eol_at_end_of_file
2 issues found.
--------------------------------------------------------------------------------
${'-' * terminalWidth}
b:
Analyzing b...
No issues found!
b: SUCCESS
--------------------------------------------------------------------------------
${'-' * terminalWidth}
c:
Analyzing c...
No issues found!
c: SUCCESS
--------------------------------------------------------------------------------
${'-' * terminalWidth}
$ melos analyze
\$ melos analyze
└> dart analyze --fatal-infos
└> FAILED (in 1 packages)
└> a (with exit code 1)
Expand All @@ -114,12 +115,12 @@ $ melos analyze

expect(
logger.output.normalizeNewLines(),
ignoringAnsii(r'''
$ melos analyze
ignoringAnsii('''
\$ melos analyze
└> dart analyze --fatal-warnings
└> RUNNING (in 3 packages)
--------------------------------------------------------------------------------
${'-' * terminalWidth}
a:
Analyzing a...
Expand All @@ -133,19 +134,19 @@ warning - main.dart:3:16 - The value of the local variable 'age' isn't used. Try
info - main.dart:5:10 - Missing a newline at the end of the file. Try adding a newline at the end of the file. - eol_at_end_of_file
8 issues found.
--------------------------------------------------------------------------------
${'-' * terminalWidth}
b:
Analyzing b...
No issues found!
b: SUCCESS
--------------------------------------------------------------------------------
${'-' * terminalWidth}
c:
Analyzing c...
No issues found!
c: SUCCESS
--------------------------------------------------------------------------------
${'-' * terminalWidth}
$ melos analyze
\$ melos analyze
└> dart analyze --fatal-warnings
└> FAILED (in 1 packages)
└> a (with exit code 2)
Expand All @@ -169,12 +170,12 @@ $ melos analyze

expect(
logger.output.normalizeNewLines(),
ignoringAnsii(r'''
$ melos analyze
ignoringAnsii('''
\$ melos analyze
└> dart analyze --no-fatal-warnings
└> RUNNING (in 3 packages)
--------------------------------------------------------------------------------
${'-' * terminalWidth}
a:
Analyzing a...
Expand All @@ -189,19 +190,19 @@ warning - main.dart:3:16 - The value of the local variable 'age' isn't used. Try
8 issues found.
a: SUCCESS
--------------------------------------------------------------------------------
${'-' * terminalWidth}
b:
Analyzing b...
No issues found!
b: SUCCESS
--------------------------------------------------------------------------------
${'-' * terminalWidth}
c:
Analyzing c...
No issues found!
c: SUCCESS
--------------------------------------------------------------------------------
${'-' * terminalWidth}
$ melos analyze
\$ melos analyze
└> dart analyze --no-fatal-warnings
└> SUCCESS
'''),
Expand All @@ -225,12 +226,12 @@ $ melos analyze

expect(
logger.output.normalizeNewLines(),
ignoringAnsii(r'''
$ melos analyze
ignoringAnsii('''
\$ melos analyze
└> dart analyze --fatal-infos --fatal-warnings
└> RUNNING (in 3 packages)
--------------------------------------------------------------------------------
${'-' * terminalWidth}
a:
Analyzing a...
Expand All @@ -244,19 +245,19 @@ warning - main.dart:3:16 - The value of the local variable 'age' isn't used. Try
info - main.dart:5:10 - Missing a newline at the end of the file. Try adding a newline at the end of the file. - eol_at_end_of_file
8 issues found.
--------------------------------------------------------------------------------
${'-' * terminalWidth}
b:
Analyzing b...
No issues found!
b: SUCCESS
--------------------------------------------------------------------------------
${'-' * terminalWidth}
c:
Analyzing c...
No issues found!
c: SUCCESS
--------------------------------------------------------------------------------
${'-' * terminalWidth}
$ melos analyze
\$ melos analyze
└> dart analyze --fatal-infos --fatal-warnings
└> FAILED (in 1 packages)
└> a (with exit code 2)
Expand Down Expand Up @@ -378,29 +379,29 @@ $ melos analyze

expect(
logger.output.normalizeNewLines(),
ignoringAnsii(r'''
$ melos analyze
ignoringAnsii('''
\$ melos analyze
└> dart analyze --concurrency 2
└> RUNNING (in 3 packages)
--------------------------------------------------------------------------------
${'-' * terminalWidth}
a:
Analyzing a...
No issues found!
a: SUCCESS
--------------------------------------------------------------------------------
${'-' * terminalWidth}
b:
Analyzing b...
No issues found!
b: SUCCESS
--------------------------------------------------------------------------------
${'-' * terminalWidth}
c:
Analyzing c...
No issues found!
c: SUCCESS
--------------------------------------------------------------------------------
${'-' * terminalWidth}
$ melos analyze
\$ melos analyze
└> dart analyze --concurrency 2
└> SUCCESS
'''),
Expand All @@ -424,32 +425,32 @@ $ melos analyze

expect(
logger.output.normalizeNewLines(),
ignoringAnsii(r'''
$ melos analyze
ignoringAnsii('''
\$ melos analyze
└> dart analyze --fatal-infos --concurrency 2
└> RUNNING (in 3 packages)
--------------------------------------------------------------------------------
${'-' * terminalWidth}
a:
Analyzing a...
info - main.dart:3:13 - Don't invoke 'print' in production code. Try using a logging framework. - avoid_print
info - main.dart:5:10 - Missing a newline at the end of the file. Try adding a newline at the end of the file. - eol_at_end_of_file
2 issues found.
--------------------------------------------------------------------------------
${'-' * terminalWidth}
b:
Analyzing b...
No issues found!
b: SUCCESS
--------------------------------------------------------------------------------
${'-' * terminalWidth}
c:
Analyzing c...
No issues found!
c: SUCCESS
--------------------------------------------------------------------------------
${'-' * terminalWidth}
$ melos analyze
\$ melos analyze
└> dart analyze --fatal-infos --concurrency 2
└> FAILED (in 1 packages)
└> a (with exit code 1)
Expand Down
Loading

0 comments on commit a497208

Please sign in to comment.