Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: .idea/modules.xml should always uses / instead of \ #582

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

AlexV525
Copy link
Contributor

Resolves #581.

Description

Replace all \ with / regardless of platforms.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2023

CLA assistant check
All committers have signed the CLA.

@AlexV525 AlexV525 marked this pull request as ready for review September 21, 2023 12:37
@AlexV525
Copy link
Contributor Author

cc @blaugold

@Salakar Salakar marked this pull request as draft November 6, 2023 15:22
@Salakar Salakar marked this pull request as ready for review November 6, 2023 15:22
@Salakar
Copy link
Member

Salakar commented Nov 6, 2023

@AlexV525 re you able to sync with main and then I can merge this, thanks

@AlexV525
Copy link
Contributor Author

AlexV525 commented Nov 6, 2023

@AlexV525 re you able to sync with main and then I can merge this, thanks

@Salakar Done. It can be done once you've setup an update button in the repo setting and you'll be not required to ask for updates. :)

@Salakar
Copy link
Member

Salakar commented Nov 6, 2023

@AlexV525 re you able to sync with main and then I can merge this, thanks

@Salakar Done. It can be done once you've setup an update button in the repo setting and you'll be not required to ask for updates. :)

I wondered where the option vanished to 😫 thanks
image

@Salakar Salakar merged commit 5d49c4a into invertase:main Nov 6, 2023
9 checks passed
@AlexV525
Copy link
Contributor Author

AlexV525 commented Nov 6, 2023

I wondered where the option vanished to 😫 thanks image

This should be it.

@AlexV525 AlexV525 deleted the fix/idea-module-path-on-windows branch November 6, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: .idea/modules.xml should not produce \ on Windows
3 participants