Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added missing execution of melos bootstrap in getting started file #615

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

PrimaryFeather
Copy link
Contributor

Description

While the Getting Started document tells the user about the importance of bootstrapping, the actual melos bootstrap command is neither shown nor executed. This is not a major problem, but I tripped over it while following the instructions, so I suspect it may irritate others as well.

Thus, I made that small addition.

refs #565

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • [] ✅ ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

While the "Getting Started" document tells the user about the importance of bootstrapping, the actual bootstrapping command is never shown or executed. I made that small addition.

refs invertase#565
Copy link

docs-page bot commented Dec 12, 2023

To view this pull requests documentation preview, visit the following URL:

melos.invertase.dev/~615

Documentation is deployed and generated using docs.page.

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@spydon spydon merged commit 4c7fd17 into invertase:main Dec 14, 2023
10 checks passed
@PrimaryFeather PrimaryFeather deleted the patch-1 branch December 15, 2023 06:48
@PrimaryFeather
Copy link
Contributor Author

Thanks a lot for accepting the pull request, guys! Keep up the great work with Melos! 😃

Salakar pushed a commit that referenced this pull request Dec 29, 2023
… file (#615)

While the "Getting Started" document tells the user about the importance of bootstrapping, the actual bootstrapping command is never shown or executed. I made that small addition.

refs #565

Co-authored-by: Lukas Klingsbo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants