Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Create commit when --no-git-tag-version is used #625

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

spydon
Copy link
Collaborator

@spydon spydon commented Jan 7, 2024

Description

This PR enables the changes in the workspace to be committed when --no-tag-tag-version is used, just like they are when it isn't used.

Closes #622

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

Copy link

docs-page bot commented Jan 7, 2024

To view this pull requests documentation preview, visit the following URL:

melos.invertase.dev/~625

Documentation is deployed and generated using docs.page.

@spydon
Copy link
Collaborator Author

spydon commented Jan 8, 2024

There is no easy way to test this, or at least we don't have the structure for testing things like this inside of the project yet if I'm not mistaken.

@spydon spydon changed the title fix: Create commit when --no-git-tag-version is used fix!: Create commit when --no-git-tag-version is used Jan 11, 2024
@spydon spydon force-pushed the fix/create-commit-with-no-tag branch from 21f0a53 to 123f34b Compare January 11, 2024 10:14
@spydon spydon merged commit b89133d into main Jan 11, 2024
10 checks passed
@spydon spydon deleted the fix/create-commit-with-no-tag branch January 11, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: --no-git-tag-version does not create a commit
2 participants