Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Init command #780

Merged
merged 11 commits into from
Nov 24, 2024
Merged

feat: Init command #780

merged 11 commits into from
Nov 24, 2024

Conversation

exaby73
Copy link
Contributor

@exaby73 exaby73 commented Oct 23, 2024

Closes #773

Description

Adds init command to melos

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

Copy link

docs-page bot commented Oct 23, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/melos~780

Documentation is deployed and generated using docs.page.

Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to this feature!

packages/melos/lib/src/command_runner/init.dart Outdated Show resolved Hide resolved
argParser.addMultiOption(
'packages',
abbr: 'p',
help: 'Comma separated packages to add in top level `packages` array',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
help: 'Comma separated packages to add in top level `packages` array',
help: 'Comma separated packages to add in top level `packages` array.',

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should probably be a bit more descriptive, "add in top level packages array" doesn't really say much to the user.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at what I have now "Comma separated glob paths to add to the melos workspace."

packages/melos/lib/src/command_runner/init.dart Outdated Show resolved Hide resolved
packages/melos/lib/src/command_runner/init.dart Outdated Show resolved Hide resolved
packages/melos/lib/src/commands/init.dart Outdated Show resolved Hide resolved
packages/melos/lib/src/commands/init.dart Outdated Show resolved Hide resolved
packages/melos/lib/src/commands/init.dart Show resolved Hide resolved
packages/melos/lib/src/commands/init.dart Outdated Show resolved Hide resolved
packages/melos/lib/src/commands/runner.dart Outdated Show resolved Hide resolved
packages/melos/lib/src/commands/runner.dart Show resolved Hide resolved
packages/melos/lib/src/command_runner/init.dart Outdated Show resolved Hide resolved
packages/melos/lib/src/commands/init.dart Outdated Show resolved Hide resolved
packages/melos/lib/src/commands/init.dart Outdated Show resolved Hide resolved
packages/melos/lib/src/commands/runner.dart Show resolved Hide resolved
packages/melos/lib/src/commands/runner.dart Outdated Show resolved Hide resolved
@exaby73 exaby73 requested a review from spydon November 24, 2024 12:24
@exaby73 exaby73 marked this pull request as ready for review November 24, 2024 12:24
Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some tests missing, otherwise it looks good!

docs/commands/init.mdx Outdated Show resolved Hide resolved
docs/commands/init.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@spydon spydon merged commit 399a016 into main Nov 24, 2024
10 checks passed
@spydon spydon deleted the feat/init branch November 24, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request: Add init command to bootstrap a melos project
2 participants