Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(app, other): add a note about dynamic initialization on other #8151

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

mikehardy
Copy link
Collaborator

Description

this was confusing to users because the install notes are very specific about how to do initialization with the firebase config on the native platforms, but there was no mention of the completely different style needed for "other" / web

Related issues

Release Summary

conventional commits ready for rebase-merge as ever

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Just review for working, docs only at current


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 3:17pm

this was confusing to users because the install notes are very specific
about how to do initialization with the firebase config on the native platforms,
but there was no mention of the completely different style needed for "other" / web
@mikehardy
Copy link
Collaborator Author

finally got all the internal links correct, I struggle with that every time! But tested and working now

@mikehardy mikehardy merged commit 11c7fa8 into main Nov 20, 2024
11 checks passed
@mikehardy mikehardy deleted the @mikehardy/other-platform-install-note branch November 20, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants