Let react-query manage observer count #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
this lgtm, I'll see if i can get tests to pass :) Thanks!! |
|
hmm i'm not sure this is working properly when a key is changed? At least that seems to be why this first test is failing |
|
It should work with changing keys since the hook will run with the new key and notice there is no queryCacheUnsubscribe with that subscriptionHash or a firestoreUnsubscribe. Therefore it will subscribe to both the queryCache and firestore itself. The old key will get 0 subscribers and be cleaned up. But I'll have a look at the tests this weekend. I'm able to run them now and see the test failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25 (comment)
React-query-firebase was managing it's own observerCount, but it was incorrect. React-query already does this and is was correct.
When there are no observers firestore is unsubscribed. If there are observers it is added again.
Also improved the readability of the code a bit by using more variables / helper functions.
Verified it is working in my application that was having issues.
I had some trouble running the tests.