Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #225 - compatibility with PHP 8.4 #226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fisharebest
Copy link

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes (except an unrelated test which fails in the existing code)
Fixed tickets #255
License MIT

This fix contains two changes for compatibility with PHP 8.4

  • Implicit null function parameters changed to explicit null. e.g. (Foo $foo = null) becomes (?Foo $foo = null)`
  • Add new property to CommonParser, prevent "cannot create dynamic properties"

It also updates the test script to include recent versions of PHP.

@fisharebest
Copy link
Author

This PR supercedes #215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant