This PR is implementing the another "result" function for the $ (selector) function .
#1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elector`) function . The new "result" function `toArray()` returns an `array of strings` which is an usual array with has all selected `id's` and you can apply all appropriate arrays methods to it. The reason of this PR - in some cases, you need to get the array of strings from the `selector`, instead of use the current `each` iterator. Moreover, the source data already presented as an array of strings, so you don't need to iterate it once more time. Changed files: - `lib/javascript.d.ts`: updated declaration of `$` - the `toArray() is added; - `lib/sandbox.js`: implementation of the `toArray()` function; - `test/testFunctions.js`: test added for the `toArray()` function; - `docs/en/javascript.md`: documentation updates of the `$` function description.
|
Thank you! This could the replace the weird |
You are always welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new "result" function
toArray()returns anarray of stringswhich is an usual array with has all selectedid'sand you can apply all appropriate arrays methods to it.The reason of this PR - in some cases, you need to get the array of strings from the
selector, instead of use the currenteachiterator. Moreover, the source data already presented as an array of strings, so you don't need to iterate it once more time.Changed files:
lib/javascript.d.ts: updated declaration of$- the `toArray() is added;lib/sandbox.js: implementation of thetoArray()function;test/testFunctions.js: test added for thetoArray()function;docs/en/javascript.md: documentation updates of the$function description.