[fix]: UI upgrade now runs as the same user as the js-controller #2950
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the issue which is closed by this PR
See this problem here https://forum.iobroker.net/topic/77574/änderungen-iob-cli-installer-fixer-mit-root-accounts/116?_=1729624052577
Implementation details
Currently the UI upgrade runs as root as the upgrade process needs to be started via
systemd
to survive the stop of the controller which runs assystemd
itself. This has the downside that everything includingnpm
is executed asroot
.Hence, the
/opt/iobroker/node_modules/iobroker.js-controller/
content and likely other modules touched by npm are now owned by root.Due to permission errors it seems that the
iobroker
user cannot read the users file and is not able to start thesystemd
viasudo -u iobroker
leading toHence, we need another solution. This solution proposed here requires the controller to pass the current
uid
andgid
to the upgrade process which then degrades itself fromroot
to the givengid
anduid
.Tests
If no tests added, please specify why it was not possible
Would need to upgrade the controller and a specific setup