Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and fixes #372

Merged
merged 2 commits into from
May 25, 2024
Merged

Updates and fixes #372

merged 2 commits into from
May 25, 2024

Conversation

Apollon77
Copy link
Collaborator

  • updates deps
  • switch to adapter-dev
  • prevent invalid property storeMap in objects and fix
  • update gha

* updates deps
* switch to adapter-dev
* prevent invalid property storeMap in objects and fix
* update gha
@Apollon77
Copy link
Collaborator Author

@mcm1957 Please look over it ... thank you

@mattreim also if you like :-)

@mcm1957
Copy link
Contributor

mcm1957 commented May 25, 2024

@Apollon77

.gitignore
package-lock.json should not be ignored (would confolict with npm ci as far as I know)

package.json:
engines clause should be set to node >= 18

"node": ">=4.0.0"

io-package.json:
at least js-controller 4.0.28 (?) oder better 5.0.19 should be required
at least admin 5, better admin 6.x.x must be required (jsonConfig)

"js-controller": ">=2.0.0"

admin/index.html and admin/index_m.html are obsolete and could be removed as jsonConfig is used

optional:
common.license should be replaced by licenseInformation
common.title could be removed
as far as I know common.materialize is obsolete as adminUi: json is specified - but not 100% sure.

I would suggest to migrate testing to standard @iobroker/testing. But this should ev. be discussed at telegram.

CODE changes:
As I do not know the functionality, I cannot ensiure that the changes are ok. I did not see any obvios problems.

@Apollon77
Copy link
Collaborator Author

materialize would still be used for older admins without jsonconfig. Rest adjusted

@Apollon77 Apollon77 merged commit 16caaff into master May 25, 2024
25 checks passed
@Apollon77 Apollon77 deleted the upd branch May 25, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants