Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed issues with BulkEdtior (dialog not closing and other dialog sho… #297

Merged
merged 2 commits into from
Jan 9, 2024
Merged

fixed issues with BulkEdtior (dialog not closing and other dialog sho… #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51a7825
fixed issues with BulkEdtior (dialog not closing and other dialog sho…
foxriver76 Jan 9, 2024
8d19702
formatting
foxriver76 Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ E.g., if it was used in a menu and the menu is red, the circle would be red.
### **WORK IN PROGRESS**
* (foxriver76) fixed last change y-offset for some widgets
* (foxriver76) fixed issue where JquiState did not respect data type
* (foxriver76) fixed issues with BulkEdtior (dialog not closing and other dialog showing wrong button)

### 2.9.13 (2024-01-08)
* (foxriver76) correctly detect IDs in bindings when they contain hash character
Expand Down
6 changes: 3 additions & 3 deletions src/src/Vis/Widgets/JQui/BulkEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ interface BulkEditorState {
iconDialog: null | number;
imageDialog: null | number;
dialog: boolean;
dialogDelete: null | false | number;
dialogDelete: null | number;
numbers?: boolean;
}

Expand Down Expand Up @@ -394,7 +394,7 @@ class BulkEditor extends React.Component<BulkEditorProps, BulkEditorState> {
// @ts-expect-error this is fine
color="grey"
startIcon={<Close />}
onClick={() => this.setState({ dialogDelete: false })}
onClick={() => this.setState({ dialogDelete: null })}
>
{I18n.t('Cancel')}
</Button>
Expand Down Expand Up @@ -696,7 +696,7 @@ class BulkEditor extends React.Component<BulkEditorProps, BulkEditorState> {
{this.state.values[i]}
<IconButton
size="small"
onClick={() => this.setState({ editDialog: { add: false, index: i, value: this.state.values[i] } })}
onClick={() => this.setState({ editDialog: { add: true, index: i, value: this.state.values[i] } })}
>
<Edit />
</IconButton>
Expand Down
Loading