Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of project and integration root directories. #4608

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

sonntag-philipp
Copy link

Hello there,
I tried to fix a, in my opinion, very confusing error message.
image

It is possible to see this message even when the cli is correctly installed and configured. The error message doesn't distinguish between errors in the CLI command (ng) and it's parameters (--port=8101).
This error will also show up, when a configuration in the project is not correctly set, which could be extremely confusing.
A good example would be this issue.

I solved this by validating the command without parameters.

@imhoffd imhoffd linked an issue Nov 13, 2020 that may be closed by this pull request
@sonntag-philipp sonntag-philipp changed the title Issue/4599 Validation of project and integration root directories. Nov 21, 2020
@sonntag-philipp
Copy link
Author

The tests fail due to missing directory paths. The paths won't get set because the directory doesn't exist.
I'm not sure how to modify the unit tests to fix this. Any ideas @dwieeb?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI can't find global packages or npm. Maybe wrong path config?
1 participant