feat(segment): add playground & docs for segment view #3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tanner-reits
commented
Nov 1, 2024
brandyscarney
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Tested locally using the dev build with all demos & StackBlitz examples. Note for anyone running this locally you will have to comment out this usage to avoid errors:
---
title: "ion-segment-view"
---
<!-- import Props from '@ionic-internal/component-api/v8/segment-view/props.md';
import Events from '@ionic-internal/component-api/v8/segment-view/events.md'; -->
<!-- ## Properties
<Props />
## Events
<Events /> -->Looks good! 👍
thetaPC
requested changes
Nov 1, 2024
tanner-reits
added a commit
that referenced
this pull request
Nov 4, 2024
* feat(segment): add playground & docs for segment view * fix(segment-view): api import version * fix(segment-content): usage & common API sections * Force CI run
tanner-reits
added a commit
that referenced
this pull request
Nov 4, 2024
* docs(select): add `modal` interface to `ion-select` docs (#3872) * docs(select): update select docs for modal interface * fix(select): point playground to correct demo * feat(segment): add playground & docs for segment view (#3875) * feat(segment): add playground & docs for segment view * fix(segment-view): api import version * fix(segment-content): usage & common API sections * Force CI run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: These docs are for an unreleased feature, to test, please update the version used by the playgrounds and component API plugin to the following dev build:
8.3.4-dev.11730395663.1a0f4848What's Changed:
ion-segmentdocs for new "swipeable segments"ion-segment-contentandion-segment-viewAssociated feature PR: ionic-team/ionic-framework#29969