-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sigs.k8s.io/cluster-api from 1.5.0 to 1.6.1 #18
Bump sigs.k8s.io/cluster-api from 1.5.0 to 1.6.1 #18
Conversation
Blocked by: kubernetes-sigs/cluster-api#9882 |
3fbbb06
to
b96d0a5
Compare
Quality Gate failedFailed conditions 75.0% Coverage on New Code (required ≥ 80%) |
A newer version of sigs.k8s.io/cluster-api exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps [sigs.k8s.io/cluster-api](https://github.com/kubernetes-sigs/cluster-api) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/kubernetes-sigs/cluster-api/releases) - [Commits](kubernetes-sigs/cluster-api@v1.5.0...v1.6.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/cluster-api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
b96d0a5
to
662a269
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but keep in mind that the event broadcaster from controller-runtime logs at V(1)
, which is too low IMO. Events aren't really used right now, but if they are introduced the log level of the manager should be increased.
actually, we are not publishing events |
Yes, that's what I meant. But if you ever start to, keep the log level in mind |
Bumps sigs.k8s.io/cluster-api from 1.5.0 to 1.6.0.
Release notes
Sourced from sigs.k8s.io/cluster-api's releases.
... (truncated)
Commits
14efefe
Merge pull request #9812 from k8s-infra-cherrypick-robot/cherry-pick-9798-to-...b0c1d91
Remove clusterctl config for proxmox from quickstart docsb014cc1
Add Proxmox infrastructure provider to clusterctl7cab626
Add Proxmox provider quickstartaaba1ef
Merge pull request #9802 from k8s-infra-cherrypick-robot/cherry-pick-9791-to-...5bc1b1a
Use ssa Patch to create machines in MP controllercb515e4
Merge pull request #9788 from k8s-infra-cherrypick-robot/cherry-pick-9777-to-...cdbe583
clusterresourceset: requeue after 1 minute if ErrClusterLocked got hit58100d7
Merge pull request #9761 from k8s-infra-cherrypick-robot/cherry-pick-9737-to-...73c6166
Improve output of exec.KubectlApplyDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions