-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional TLS certificate checking when talking to Proxmox #336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions, PR looks good unto itself (minus the boolean cast).
On top of the questions, we're missing documentation and work on how to map secrets as files into a deployment into SSL_CERT_DIR. That could be scoped to a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this going in. Do or do not implement checking on whether data["insecure"]
exists at your own leisure.
a15d081
to
36f47e1
Compare
6cc8f97
to
8fe7e0c
Compare
Quality Gate failedFailed conditions |
I'm ok with the barely-missed coverage% target in this case. |
Issue #, if available: #192
Description of changes:
Testing performed: