Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

step 2 to fix 132 #135

Merged
merged 5 commits into from
Mar 31, 2023
Merged

step 2 to fix 132 #135

merged 5 commits into from
Mar 31, 2023

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Mar 27, 2023 •
edited
Loading

xref.: #132 (comment)

  • add note on jupyter-lab and jupyter nbclassic in this file.

@ocefpaf ocefpaf marked this pull request as draft March 27, 2023 20:03
@ocefpaf ocefpaf force-pushed the add_kernel_error_note branch from e7604b8 to 1d11743 Compare March 27, 2023 23:48
@ocefpaf ocefpaf marked this pull request as ready for review March 31, 2023 18:07
@ocefpaf ocefpaf requested a review from MathewBiddle March 31, 2023 18:08
@MathewBiddle
Copy link
Contributor

LGTM! Thanks for addressing these.

@MathewBiddle MathewBiddle merged commit fc8c01e into ioos:main Mar 31, 2023
@ocefpaf ocefpaf deleted the add_kernel_error_note branch March 31, 2023 20:04
@ocefpaf ocefpaf mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathewBiddle MathewBiddle MathewBiddle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocefpaf @MathewBiddle