Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Udate gallery for #13 #199

Merged
merged 1 commit into from
May 16, 2024
Merged

Udate gallery for #13 #199

merged 1 commit into from
May 16, 2024

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented May 16, 2024

@MathewBiddle can you take a look at the 3 keywords here, lines 330-332?

Copy link
Contributor

@MathewBiddle MathewBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those look good!

@ocefpaf ocefpaf requested a review from MathewBiddle May 16, 2024 17:17
Copy link
Contributor

@MathewBiddle MathewBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good!

@MathewBiddle MathewBiddle merged commit df10c50 into ioos:main May 16, 2024
9 of 11 checks passed
@ocefpaf
Copy link
Member Author

ocefpaf commented May 16, 2024

@MathewBiddle the URL https://www.ncei.noaa.gov/archive/accession/0282699 is breaking the page build b/c it is not accessible. Is that temporary or did the URL change? Also, we need to skip R kernels. I'll do in another PR. We are not executing them to reduce the CI time, it was way too long and they rarely break due to stable CRAN versions of the packages.

@ocefpaf ocefpaf deleted the update_gallery branch May 16, 2024 17:26
@MathewBiddle
Copy link
Contributor

Odd, I can access that url on my browser. I wonder if NCEI has some block on github requests?

@ocefpaf
Copy link
Member Author

ocefpaf commented May 16, 2024

Odd, I can access that url on my browser. I wonder if NCEI has some block on github requests?

Nope. It was down but it is back up. We can access it now as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants