This repository has been archived by the owner on Aug 23, 2020. It is now read-only.
Fix: Milestone progress bar v2 #1857
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently while running this branch I don't see this working while walking down... |
|
I just debugged... Will keep on monitoring |
kwek20
force-pushed
the
progress-bar-v2
branch
2 times, most recently
from
e731988 to
73a382c
Compare
added 2 commits
May 12, 2020 17:06
kwek20
changed the title
kwek20
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Progressbar now shows up when we walk down latest milestone -> latest solid during syncing.
Previously this only showed up when we were moving back up from latest solid -> latest.
As this part is the easy part and takes the least time, i added this
We have set a constant deciding that going down the tangle takes 95x as logn as going up and checking solidity.
Edit: Whoeps pushed the rebase of #1856
Type of change
How was this tested