new face_detection package with dlib library #36
Conversation
| ) | ||
|
|
||
| install(DIRECTORY include | ||
| DESTINATION ${CATKIN_GLOBAL_INCLUDE_DESTINATION} |
There was a problem hiding this comment.
CATKIN_PACKAGE_INCLUDE_DESTINATION
|
@Lizca: Please fix @ipa-fxm's comments and check if it is building on travis |
| set_target_properties(data_file PROPERTIES LINKER_LANGUAGE CXX) | ||
| target_link_libraries(data_file ${BZIP2_LIBRARIES}) | ||
|
|
||
| add_executable(dlib_face_detection src/dlib_face_detection.cpp include) |
There was a problem hiding this comment.
remove the include from the add_executable tags...they are not needed
|
It seems like the build problems are solved... |
| <name>dlib_lib</name> | ||
| <version>0.1.0</version> | ||
| <description> | ||
| This package wrapes the external c++ library dlib (http://dlib.net/) in a ros package, so other packages can use it. It downloads the source code of it and then builds it, corresponding to the webpage of it, using cmake. The build library is a static library and will be copied to the created common/lib folder. The neccessary header files will be copied to the common/include folder. The include folder needs to exist befor building the package, because in the CMakeLists you have to specify where the headers are and if the folder doesn't exist, catkin won't be able to build the package. For further descriptions and tutorials see the Makefile.tarball and http://dlib.net/ . |
|
|
||
| cloud_sub_ = new message_filters::Subscriber<cloud_msgT>(nh, "pointcloud_in", 10); | ||
| direct_face_sub_ = new message_filters::Subscriber<rect_msgT>(nh, "/dlib_face_detection/direct_face_detections", 10); | ||
| head_based_face_sub_ = new message_filters::Subscriber<rect_msgT>(nh, "/dlib_face_detection/head_based_face_detections", 10); |
There was a problem hiding this comment.
avoid global namespaces for pubisher and subscriber
|
some of my comments apply to several code files, e.g. "global namespaces" or "odom_combined"...did not want to put it everywhere...please have a look wherever it applies... |
|
@ipa-rmb could you please review this PR? |
|
Do we use dlib? Do you know whether there is any face detection or recognition function delivered by dlib which is superior to ours? If you do not know, I will check that. If there is no additional benefit or need for dlib, I would not like to add it to the repository as maintenance would be more intricate given this external lib. If we do not merge it to the offical main branch, we can still "save" the dlib integration work in a separate branch. |
|
we do not use dlib at the moment. I'm not aware of any mayor differences. Saving this in a separate branch is ok for me. |
|
Yes, then let's have a separate branch for this. How can I change the target branch of the pull request? |
|
you can't. We'll have to close this PR, clone the repository from Lizca, push to a branch on your fork and then open a new PR. Let me know if you need help |
|
redirected into a separate archive branch in PR #50 . |
No description provided.