Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage containers splitting #153

Merged
merged 4 commits into from
May 25, 2022
Merged

Conversation

artek-koltun
Copy link
Contributor

Provide an ability to run the images as
standalone containers outside the test scope.

Provide an ability to run the images as
standalone containers outside the test scope.

Signed-off-by: Artsiom Koltun <[email protected]>
@artek-koltun artek-koltun force-pushed the rel-split-containers branch from 5198992 to 7e5d2fb Compare May 17, 2022 15:14
@intelfisz intelfisz requested a review from mestery May 20, 2022 09:17
@mestery mestery mentioned this pull request May 24, 2022
Copy link
Contributor

@mestery mestery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a massive PR. I have taken a quick look and proposed some required things which need to happen before it can be merged. One other thing here, I don't know how you made the diagrams here, but checking in .svg files is challenging because you can't edit them easily. It would be better to use draw.io to make the graphics and save them as editable .png files. Ping me if you need help here.

.gitmodules Show resolved Hide resolved
build/scripts/run-shellcheck.sh Show resolved Hide resolved
build/storage/Dockerfile Outdated Show resolved Hide resolved
@artek-koltun
Copy link
Contributor Author

This is a massive PR. I have taken a quick look and proposed some required things which need to happen before it can be merged. One other thing here, I don't know how you made the diagrams here, but checking in .svg files is challenging because you can't edit them easily. It would be better to use draw.io to make the graphics and save them as editable .png files. Ping me if you need help here.

Thank you, Kyle!
I have not known that this editable png format exists and that's nice that it is applicable for draw.io
The diagrams are reworked. Please, have a look

Signed-off-by: Artsiom Koltun <[email protected]>
Copy link
Contributor

@mestery mestery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks or addressing my concerns!

@mestery mestery merged commit 2d906ac into ipdk-io:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants