Fixed log messages in infra manager packages #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishala-r
requested review from
nupurjai,
ahalimx86 and
Eoghan1232
as code owners
Signed-off-by: Vishalakshi <[email protected]>
Signed-off-by: Vishalakshi <[email protected]>
Signed-off-by: Vishalakshi <[email protected]>
nupurjai
previously approved these changes
Jan 12, 2023
nupurjai
dismissed
their stale review
There are test errors. Looks like one error printing is missing args
nupurjai
reviewed
Jan 12, 2023
| @@ -533,24 +527,24 @@ func (s *ApiServer) NatTranslationAdd(ctx context.Context, in *proto.NatTranslat | |||
| } | |||
|
|
|||
| if newEps == 0 { | |||
| logger.Info("No new endpoints in the service. No rules inserted") | |||
| logger.Infof("No new endpoints in the service. No rules inserted") | |||
There was a problem hiding this comment.
Can you fix this. This is causing the build failure.
Signed-off-by: Vishalakshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vishalakshi [email protected]