-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add RELEASE.md #266
docs: add RELEASE.md #266
Conversation
Codecov Report
@@ Coverage Diff @@
## main #266 +/- ##
==========================================
+ Coverage 47.88% 47.91% +0.03%
==========================================
Files 273 273
Lines 33186 33186
==========================================
+ Hits 15890 15901 +11
+ Misses 15619 15609 -10
+ Partials 1677 1676 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff Gus. Thanks for getting this critical stuff documented!
Somethings came to mind while reviewing this. I'm happy to verbal if that's quicker for you:
- Will we do release on Friday? I assume yes because this isn't a binary. Any production deployment is handled by others and that is there responsibility to make decisions on when to build and deploy. Lets document.
- What about giving credit to contributors? I'm thinking about the contributor portion of mkreleaselog.
- What's the mechanism for Kubo updating? (I realize that is Kubo's problem, not Boxo, but it's coming to mind, in part because we're opening PR's in Kubo. I assume this gets swept up in the usual "how does Kubo update its dependencies" bucket)
- Are we going to use any other announcement channels about the release? How about discuss.ipfs.tech and blog (linking to release)?
- I assume there isn't the complexity in this release to warrant having an accompanying PR where we make changes to the release process as we go (like we do with Kubo: https://www.notion.so/pl-strflt/Kubo-Release-Process-5a5d066264704009a28a79cff93062c4?pvs=4#b154fdedd1a04cdbb6b0056d654b4329 )
@@ -0,0 +1,53 @@ | |||
# Boxo Releases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this under docs/ ? Not sure the best move here, but I was thinking the FAQ.md should be there per #260
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at how this played out in 0.8. My comments/thoughts are linked below for completeness. I also made a couple of small suggestions based on some of this too.
Seems like nobody is happy w/ the changelog, we probably need to talk with @galargh about what to do there since it impacts tooling. Bringing together the various comments:
|
Is everything under "removed" a breaking change (and maybe some things under "changed")? Maybe we just make sure those are at the top? I was thinking we could even add a "Breaking Change" section header and put "Removed" under there, but maybe the better way is to add a legend here and have something like 🛠 (what we have used before) next to each line denoting a breaking change.
This should just come during the changelog addition. I see they're doing that in https://keepachangelog.com/en/1.0.0/
I don't know the full history on this, but seems like a good OSS practice to give credit to folks who contribute. That said, maybe we can just scope it to those who are contributing to Boxo directly rather than all the dependencies?
I don't think we need this in general. Ideally providing a link to the related issue is good. I was wondering if we need a tldr about the release because looking at #264 I don't think we're really calling out as well for folks about the big picture things that they may care about. Maybe this would have been done better if we were requiring a changelog addition/change per PR. Maybe too we can use another emoji (✨ ?) to highlight things people should pay attention to especially (and that's also our signal to make sure our descriptive text is particularly useful then). I like the guiding principle of "Changelogs are for humans, not machines" So maybe have something at the top of our changelog (which also gets pasted into the "release") like:
|
2023-04-11 maintainer conversation: It's clear the steps we're going to do to resolve this...
That said, we didn't answer these questions during our call:
|
Yeah I'd like to do this until we discover a reason not to, I think by default that we should bias towards release velocity. discuss.ipfs.tech seems fine. Do we have any data on how many people view release blog entries or click the links? |
21f89ba
to
6852500
Compare
Opened #277 to write down how to publish a blog entry in the release process |
62af0ec
to
dab4b07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @guseggert ! Looking good to me. I made some small suggestions, but feel free to ship whenever at this point.
Co-authored-by: Steve Loeppky <[email protected]>
No description provided.