Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockservice: remove inner fields access methods #562

Open
wants to merge 1 commit into
base: blockservice-unique
Choose a base branch
from

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jan 15, 2024

I'll add changelog if we decide this is the option we want to go with.

Copy link
Contributor Author

Jorropo commented Jan 15, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

We shouldn't expose inner implementation details of the blockservice to consumers.

For example by using the blockstore for the .Has call, the gateway skipped verifcid and blocker checks. Probably fine but not we want to do.
@Jorropo Jorropo force-pushed the blockservice-unique branch from 5e08a77 to 27a4b69 Compare January 15, 2024 17:29
@Jorropo Jorropo force-pushed the 01-15-blockservice_remove_inner_fields_access_methods branch from 17b3ed9 to 8f9efef Compare January 15, 2024 17:29
@Jorropo Jorropo marked this pull request as ready for review January 16, 2024 09:10
@hacdias hacdias removed their request for review May 27, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant