generated from ipfs/ipfs-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: add new session package #570
Draft
Jorropo
wants to merge
1
commit into
main
Choose a base branch
from
session/v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ultimately went that route because it satisfy both:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #570 +/- ##
==========================================
- Coverage 65.54% 65.29% -0.25%
==========================================
Files 206 203 -3
Lines 25587 25516 -71
==========================================
- Hits 16770 16660 -110
- Misses 7344 7372 +28
- Partials 1473 1484 +11 |
Stebalien
reviewed
Jan 22, 2024
This was referenced Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #563 and #561.
TODO:
Questions:
comparable
to ensure it doesn't panic the map, it might be interesting to enforce something likeinterface[S any]{ comparable; SessionBadge() S }
because this would enforce at compile time that the session consumer is not mixing different session types together (which would not work).GetOrCreate
return(S, error)
instead ofS, bool
?Passing errors can always be done efficiently through closures as
create
does not leak, the important part is to not save in the map failed sessions.ContextWithSession(context.Context, ...Option)
? We might want to add something like a request root in there.