Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert blockservice sessions context #578

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Feb 14, 2024

This brings us to a state before #549 back then I also did cleanup in this session code, that I have kept, I only removed the sessions in context feature.

Copy link
Contributor Author

Jorropo commented Feb 14, 2024

@Jorropo Jorropo changed the title Revert "blockservice: make ContextWithSession shortcut grabSessionFromContext inside newSession" Revert blockservice sessions context Feb 14, 2024
@Jorropo Jorropo marked this pull request as ready for review February 14, 2024 16:11
@Jorropo Jorropo requested review from lidel, hacdias and a team as code owners February 14, 2024 16:11
@Jorropo Jorropo force-pushed the revert-bad-sessions-changes branch from d152c7c to 0912ba3 Compare February 14, 2024 16:12
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.56%. Comparing base (8924807) to head (66da324).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
- Coverage   65.59%   65.56%   -0.04%     
==========================================
  Files         207      207              
  Lines       25612    25579      -33     
==========================================
- Hits        16801    16771      -30     
+ Misses       7338     7336       -2     
+ Partials     1473     1472       -1     
Files Coverage Δ
blockservice/blockservice.go 77.18% <ø> (-1.05%) ⬇️
gateway/blocks_backend.go 42.23% <ø> (+0.13%) ⬆️

... and 16 files with indirect coverage changes

@Jorropo Jorropo changed the base branch from main to 02-16-bitswap/network_split_Routing_in_two_in_interface February 16, 2024 14:00
@Jorropo Jorropo force-pushed the revert-bad-sessions-changes branch from 0912ba3 to e21efeb Compare February 16, 2024 14:00
@Jorropo Jorropo changed the base branch from 02-16-bitswap/network_split_Routing_in_two_in_interface to main February 16, 2024 14:09
@Jorropo Jorropo force-pushed the revert-bad-sessions-changes branch from e21efeb to d8d7675 Compare February 16, 2024 14:09
Jorropo added a commit to ipfs/kubo that referenced this pull request Feb 16, 2024
…mContext inside newSession"

Supperseeded by #570

This reverts commit ea04c77.
This brings us to a state before #549 back then I also did cleanup in this session code, that I have kept, I only removed the sessions in context feature.
@hacdias hacdias force-pushed the revert-bad-sessions-changes branch from d8d7675 to 66da324 Compare February 27, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants