Reenable flaky bitswap tests #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent improvements in bitswap should stabalize these tests. Closes #327
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #740 +/- ##
==========================================
+ Coverage 60.43% 60.51% +0.07%
==========================================
Files 245 245
Lines 31064 31064
==========================================
+ Hits 18774 18797 +23
+ Misses 10618 10603 -15
+ Partials 1672 1664 -8 |
lidel
reviewed
Dec 4, 2024
Comment on lines
-348
to
-349
| test.Flaky(t) | ||
|
|
There was a problem hiding this comment.
@gammazero seems to be still flaky on Windows, main branch failed: https://github.com/ipfs/boxo/actions/runs/12167338127/job/33935669596#step:13:256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent improvements in bitswap should stabalize these tests.
Closes #327