Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow disabling Kubo 'localhost' testing #210

Closed
wants to merge 1 commit into from

Conversation

SgtPooki
Copy link
Member

Fixes #185

@SgtPooki SgtPooki requested review from lidel and laurentsenta May 23, 2024 17:12
Copy link
Contributor

Results against Kubo latest:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
2049 0 0 0

Copy link
Contributor

Results against Kubo master:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
2049 0 0 0

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid we can't add Kubo-specific hacks like this to implementation-agnostic test cases.

Let's park this until we have #185 (comment) sorted out.

@SgtPooki
Copy link
Member Author

FYI I just tested this against https://github.com/ipfs/helia-verified-fetch/pull/85/files#diff-175730b97b315afceee1b708f9bd876588ef883662dc52e139a7961ac7804c56R100 and it doesn't seem to fix the problem

  @helia/verified-fetch - gateway conformance
    conformance testing
2024-05-23T17:34:33.543Z conformance-tests:before Using custom gateway-conformance binary at /Users/sgtpooki/code/work/protocol.ai/ipfs/gateway-conformance/gateway-conformance
2024-05-23T17:34:34.609Z basic-server:request:trace set fixingGwcAnnoyance to true for /ipfs/bafkreicysg23kiwv34eg2d7qweipxwosdo2py4ldv42nbauguluen5v6am/, with host header localhost
2024-05-23T17:34:34.614Z basic-server:request:trace set fixingGwcAnnoyance to true for http://localhost/ipfs/bafkreicysg23kiwv34eg2d7qweipxwosdo2py4ldv42nbauguluen5v6am/, with host header localhost
2024-05-23T17:34:34.617Z basic-server:request:trace set fixingGwcAnnoyance to true for /ipfs/bafybeig675grnxcmshiuzdaz2xalm6ef4thxxds6o6ypakpghm5kghpc34/Portugal%252C+Espa%C3%B1a=Peninsula%20Ib%C3%A9rica.txt, with host header localhost
2024-05-23T17:34:34.622Z basic-server:request:trace set fixingGwcAnnoyance to true for http://localhost/ipfs/bafybeig675grnxcmshiuzdaz2xalm6ef4thxxds6o6ypakpghm5kghpc34/Portugal%252C+Espa%C3%B1a=Peninsula%20Ib%C3%A9rica.txt, with host header localhost
2024-05-23T17:34:34.647Z basic-server:request:trace set fixingGwcAnnoyance to true for /ipfs/bafybeiht6dtwk3les7vqm6ibpvz6qpohidvlshsfyr7l5mpysdw2vmbbhe/, with host header localhost
2024-05-23T17:34:34.652Z basic-server:request:trace set fixingGwcAnnoyance to true for http://localhost/ipfs/bafybeiht6dtwk3les7vqm6ibpvz6qpohidvlshsfyr7l5mpysdw2vmbbhe/, with host header localhost
2024-05-23T17:34:34.655Z basic-server:request:trace set fixingGwcAnnoyance to true for /ipfs/QmZULkCELmmk5XNfCgTnCyFgAVxBRBXyDHGGMVoLFLiXEN/, with host header localhost
2024-05-23T17:34:34.661Z basic-server:request:trace set fixingGwcAnnoyance to true for http://localhost/ipfs/QmZULkCELmmk5XNfCgTnCyFgAVxBRBXyDHGGMVoLFLiXEN/, with host header localhost
2024-05-23T17:34:34.703Z basic-server:request:trace set fixingGwcAnnoyance to true for /ipfs/bafkreicysg23kiwv34eg2d7qweipxwosdo2py4ldv42nbauguluen5v6am/, with host header localhost
2024-05-23T17:34:34.708Z basic-server:request:trace set fixingGwcAnnoyance to true for http://localhost/ipfs/bafkreicysg23kiwv34eg2d7qweipxwosdo2py4ldv42nbauguluen5v6am/, with host header localhost
2024-05-23T17:34:34.710Z basic-server:request:trace set fixingGwcAnnoyance to true for /ipfs/QmInvalidCID, with host header localhost
2024-05-23T17:34:34.713Z basic-server:request:trace set fixingGwcAnnoyance to true for http://localhost/ipfs/QmInvalidCID, with host header localhost
2024-05-23T17:34:34.713Z basic-server:request:trace set fixingGwcAnnoyance to true for /ipfs/QmZULkCELmmk5XNfCgTnCyFgAVxBRBXyDHGGMVoLFLiXEN/, with host header localhost
2024-05-23T17:34:34.718Z basic-server:request:trace set fixingGwcAnnoyance to true for http://localhost/ipfs/QmZULkCELmmk5XNfCgTnCyFgAVxBRBXyDHGGMVoLFLiXEN/, with host header localhost
2024-05-23T17:34:34.721Z basic-server:request:trace set fixingGwcAnnoyance to true for /ipfs/bafkreicysg23kiwv34eg2d7qweipxwosdo2py4ldv42nbauguluen5v6am/, with host header localhost
2024-05-23T17:34:34.726Z basic-server:request:trace set fixingGwcAnnoyance to true for http://localhost/ipfs/bafkreicysg23kiwv34eg2d7qweipxwosdo2py4ldv42nbauguluen5v6am/, with host header localhost
2024-05-23T17:34:34.729Z basic-server:request:trace set fixingGwcAnnoyance to true for /ipfs/?uri=ipfs%3A%2F%2FQmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco%2Fwiki%2FDiego_Maradona.html, with host header localhost
2024-05-23T17:34:34.731Z basic-server:request:trace set fixingGwcAnnoyance to true for http://localhost/ipfs/?uri=ipfs%3A%2F%2FQmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco%2Fwiki%2FDiego_Maradona.html, with host header localhost
2024-05-23T17:34:34.734Z basic-server:request:trace set fixingGwcAnnoyance to true for /ipfs/bafkrgqhhyivzstcz3hhswshfjgy6ertgmnqeleynhwt4dlfsthi4hn7zgh4uvlsb5xncykzapi3ocd4lzogukir6ksdy6wzrnz6ohnv4aglcs, with host header localhost
2024-05-23T17:34:34.738Z basic-server:request:trace set fixingGwcAnnoyance to true for http://localhost/ipfs/bafkrgqhhyivzstcz3hhswshfjgy6ertgmnqeleynhwt4dlfsthi4hn7zgh4uvlsb5xncykzapi3ocd4lzogukir6ksdy6wzrnz6ohnv4aglcs, with host header localhost
      ✔ TestGatewaySubdomains has a success rate of at least 41.35% (1273ms)
2024-05-23T17:34:34.820Z conformance-tests:after Not removing custom gateway-conformance binary at /Users/sgtpooki/code/work/protocol.ai/ipfs/gateway-conformance/gateway-conformance

@SgtPooki
Copy link
Member Author

I am afraid we can't add Kubo-specific hacks like this to implementation-agnostic test cases.

I'm confused.. This PR is attempting to allow an escape hatch for dependence on Kubo specific behavior.

@lidel
Copy link
Member

lidel commented May 23, 2024

Sorry, what I meant is that we should fix conformance tests and not introduce configuration with "kubo" in name to work around have dependency on Kubo specific behavior.

I'll see if we can do this in generic way, without any workarounds.

Update: i'm tracking fixes in #185 (comment)

@lidel lidel marked this pull request as draft May 23, 2024 23:21
@lidel
Copy link
Member

lidel commented Jun 10, 2024

Hardcoded matrix that run subdomain tests against localhost is removed in #211, which will ship in v6, so closing this one.

Once that PR is merged, tests will be run against --subdomain-url, and there will be no implicit tests against host that was not explicitly passed via this parameter.

@lidel lidel closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: gateway-conformance subdomains are inflexible and setup is not clear
2 participants