-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow disabling Kubo 'localhost' testing #210
Conversation
Results against Kubo latest: Summary
|
Results against Kubo master: Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid we can't add Kubo-specific hacks like this to implementation-agnostic test cases.
Let's park this until we have #185 (comment) sorted out.
FYI I just tested this against https://github.com/ipfs/helia-verified-fetch/pull/85/files#diff-175730b97b315afceee1b708f9bd876588ef883662dc52e139a7961ac7804c56R100 and it doesn't seem to fix the problem
|
I'm confused.. This PR is attempting to allow an escape hatch for dependence on Kubo specific behavior. |
Sorry, what I meant is that we should fix conformance tests and not introduce configuration with "kubo" in name to work around have dependency on Kubo specific behavior. I'll see if we can do this in generic way, without any workarounds. Update: i'm tracking fixes in #185 (comment) |
Hardcoded matrix that run subdomain tests against Once that PR is merged, tests will be run against |
Fixes #185